Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T1687 - Cannot log calls in interaction resume #1944

Merged
merged 4 commits into from
Aug 13, 2024
Merged

T1687 - Cannot log calls in interaction resume #1944

merged 4 commits into from
Aug 13, 2024

Conversation

clementcharmillot
Copy link
Contributor

@clementcharmillot clementcharmillot commented Aug 12, 2024 •
edited
Loading

Details

Fix an exception when logging a call from the wizard shown by pressing Log Call and submitting a log.
image

Solution

  • Added back the communication_id field on the model crm_phonecall as it is the most conservative approach. Field removed in commit fcf0b20.
  • If we don't want this field anymore, call_log should be edited to not pass a communication_id in file compassion-modules/partner_communication_crm_phone/wizards/call_wizard.py.

compassion-modules/partner_communication_crm_phone/wizards/call_wizard.py

Lines 46 to 52 in 8bdb323

call_vals = {
"state": state,
"description": self.comments,
"name": communication.config_id.name,
"communication_id": communication_id,
"partner_id": communication.partner_id.id,
}

@clementcharmillot clementcharmillot marked this pull request as ready for review August 12, 2024 10:09
@clementcharmillot clementcharmillot self-assigned this Aug 12, 2024
ecino
ecino requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact I would prefer the less conservative approach and remove the field value from the log wizard.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ecino ecino merged commit fcb5c50 into 14.0 Aug 13, 2024
1 of 2 checks passed
@ecino ecino deleted the T1687-cannot-log-calls-interaction-resume branch August 13, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecino ecino ecino approved these changes

Assignees

@clementcharmillot clementcharmillot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clementcharmillot @ecino